Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(style): remove unnecessary eui exports #1636

Merged
merged 1 commit into from
Mar 30, 2022
Merged

fix(style): remove unnecessary eui exports #1636

merged 1 commit into from
Mar 30, 2022

Conversation

markov00
Copy link
Member

Summary

This fix reverts a suggestion that imported unwanted classes into our exported CSS files.
We are now importing only mixins and variables that will not pollute the generated CSS with unwanted classes like the date picker and some utility classes

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)

@markov00 markov00 added :styling Styling related issue :all Applies to all chart types labels Mar 30, 2022
@nickofthyme nickofthyme merged commit 3b8243c into elastic:master Mar 30, 2022
@nickofthyme nickofthyme changed the title fix(style): don't export EUI styles fix(style): remove unnecessary eui exports Mar 30, 2022
@markov00 markov00 deleted the 2022_03_30-fix_eui_exported_sass branch April 11, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees
No one assigned
Labels
:all Applies to all chart types :styling Styling related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markov00 @nickofthyme